search

jeresig / pulley

Easy Github Pull Request Lander
MIT License
175 stars 24 forks source link

better detection of issue number! #31

Closed mikesherov closed 12 years ago

mikesherov commented 12 years ago

currently, it expects issues to be a # followed by a 4-5 digit number. That's not a good enough regex.

sindresorhus commented 12 years ago

I don't think we can create a generalized enough regex, there are so many ways to do it.

Suggestion: Add a property in the issues config to specify a regex to override the default, per issue?

mikesherov commented 12 years ago

How about this:

findBug = /(?:ref|refs|close|closes|fix|fixes)\s+#(\d+)/ig,

sindresorhus commented 12 years ago

That still leaves: fixed, closed, resolved

If you add those it will work with GitHub issue references, but other systems might work differently, by eg. using different words or dropping the #.