polls - Githubissues

jerimiah-smiggins / smiggins

a social media platform that i made so that means its cool

https://trinkey.pythonanywhere.com

GNU General Public License v3.0

7 stars 5 forks source link

polls #187

Closed trinkey closed 3 months ago

trinkey commented 3 months ago

What does this do?

adds polls and adds an option to the backend that automatically sends a webhook to the specified url when someone with a username makes a post, and adds a bunch more backend toggles

Issues completed:

fixes #105
fixes #184
fixes #188
fixes #190

Checklist for Reviewers

[x] Version has been incremented (if appropriate)
[x] BACKEND.md has been updated for any new functions
[x] Any new changes have been tested thoroughly (including api calls that wouldn't normally be possible using inspect element or the /api/docs page)
[x] Any changes have been documented in the changelog.logs part of the en-US language file, along with the minor language version being incremented
[x] Features that break easily have been tested (mostly viewing pages when not logged in)

Subroutine7901 commented 3 months ago

ok uh I open a post (.com/p/number) I vote I go back with the browser's back button poll no have vote on home page I click? nothing I reload now the results and my vote show up huh also there's an issue with the account switcher so maybe make it so if you switch to an account it deletes it and then logs you out like you were adding a new account instead of just logging out for a new account that'd be good It also had another thing so just play around with switching to a deleted account

trinkey commented 3 months ago

I go back with the browser's back button poll no have vote on home page

this is a browser caching issue not a smiggins issue, no way to easily fix this

trinkey commented 3 months ago

also there's an issue with the account switcher

i didn't change much besides adding a toggle? i can check though

trinkey commented 3 months ago

oh you're talking about switching to a deleted account i get it

fixing that would require rewriting a bunch of the account switcher functionality and i don't want to worry about that

in general switching to a deleted account should happen almost never unless someone messed up badly

trinkey commented 3 months ago

someone should review my pr (@Subroutine7901)

Subroutine7901 commented 3 months ago

All the issues I talked about were addressed so I guess its good