title bar has artifacts for non-native X11 clients

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Start wmii and some clients
2. Kill wmii (xwrite /ctl kill) only
3. Make your .xinitrc re-run wmii
4. Observe the situation shown in the attached screenshot

What is the expected output? What do you see instead?

For non-native X11 clients (such as GTK+ and Java), the title bar is not
rendered properly:  there is a 5px? gap where a gray/white dotted pattern
appears at the bottom of the title bar and extends to the width of the
client as it was before wmii was killed.

I do not expect to see these graphical artifacts.

What version of the product are you using (wmii -v)? On what operating
system?

wmii-hg2515, ©2009 Kris Maglione

Please provide any additional information below.

To correct the problem, I simply reapply a colmode (such as stack or
default) and the title bars correct themselves.

Original issue reported on code.google.com by sun...@gmail.com on 2 Oct 2009 at 9:38

Attachments:

• bug.png

[GoogleCodeExporter]

Original comment by sun...@gmail.com on 2 Oct 2009 at 9:39

• Changed title: title bar has artifacts for non-native X11 clients

[GoogleCodeExporter]

This is more of a low priority defect than an enhancement.  

Original comment by sun...@gmail.com on 2 Oct 2009 at 9:40

• Added labels: Priority-Low, Type-Defect
• Removed labels: Type-Enhancement

[GoogleCodeExporter]

Works for me (kill isn't a /ctl command, though).

Original comment by maglion...@gmail.com on 2 Oct 2009 at 10:02

[GoogleCodeExporter]

Interesting.  Maybe it's because of the the wmii font I'm using?

I use size 18, whereas the default wmiirc setting is 13:

  -*-fixed-medium-r-*-*-18-*-*-*-*-*-*-*

Original comment by sun...@gmail.com on 2 Oct 2009 at 10:13

[GoogleCodeExporter]

Yes, that was it.  With font size 13, I do not see the problem.

But with font size 18, I *do* see the problem.  Thanks.

Original comment by sun...@gmail.com on 2 Oct 2009 at 10:14

[GoogleCodeExporter]

I still can't duplicate this, even with your wmiirc, running urxvt, mlterm, 
xfontsel,
gfontsel, abraca, and gpa.

Original comment by maglion...@gmail.com on 2 Oct 2009 at 10:53

[GoogleCodeExporter]

I just stumbled across this by accident, actually. It happens when changing to 
a larger font from a smaller one. 
Sometimes. Irrespective of the application.

Original comment by maglion...@gmail.com on 4 Oct 2009 at 5:51

• Changed state: Accepted

[GoogleCodeExporter]

I've only been able to reproduce this once. Can you try the applied patch and 
see if
it makes a difference?

Original comment by maglion...@gmail.com on 6 Oct 2009 at 8:09

Attachments:

• collapsed-clients-hide.patch

[GoogleCodeExporter]

Yes, that patch fixes the problem!  Thanks.

Original comment by sun...@gmail.com on 6 Oct 2009 at 9:36

[GoogleCodeExporter]

Original comment by sun...@gmail.com on 7 Oct 2009 at 6:13

• Changed state: Started

[GoogleCodeExporter]

The fix is in my patch queue. I'll push it soon.

Original comment by maglion...@gmail.com on 8 Oct 2009 at 5:39

[GoogleCodeExporter]

Original comment by maglion...@gmail.com on 18 Oct 2009 at 10:08

• Changed state: Fixed

[GoogleCodeExporter]

Hi Kris,

This issue is marked as being fixed, but I don't yet see the patch for this fix 
in
the wmii Hg repository.  I am still using the patch locally in my checkout of 
the
wmii Hg repository:

sun@yantram ~/l/s/wmii> hg diff
diff -r b89fc205928c cmd/wmii/client.c
--- a/cmd/wmii/client.c Fri Oct 23 04:39:11 2009 -0400
+++ b/cmd/wmii/client.c Fri Oct 23 05:47:52 2009 -0700
@@ -530,6 +530,7 @@
            unmap_frame(c);
        else {
            reshapewin(c->framewin, f->r);
+           reshapewin(&c->w, f->crect);
            map_frame(c);
        }
        client_unmap(c, IconicState);

Thanks.

Original comment by sun...@gmail.com on 23 Oct 2009 at 12:49

[GoogleCodeExporter]

Original comment by sun...@gmail.com on 23 Oct 2009 at 12:50

• Changed state: Verified

[GoogleCodeExporter]

This issue was closed by revision 0d74eec149.

Original comment by maglion...@gmail.com on 23 Oct 2009 at 12:56

• Changed state: Fixed