search

jermartin77 / plusgallery

A responsive javascript based image gallery driven by photos from a 3rd party source.
61 stars 35 forks source link

Loading Plus Gallery Through Ajax #6

Closed ArledgeMike closed 11 years ago

ArledgeMike commented 11 years ago

Jer first off man, solid work. This plugin works flawlessly and elegantly on the most straightforward sites. I am having a small problem when I load the plus gallery using AJAX.

www.ychicago.com/projectwinters

To recreate the bug click on the "Gallery" menu option and panel will slide in and load the Plus Gallery.

Next click on another menu option. The panel should change content (please pardon the lack of animation is we are still in dev)

Next click back to the Gallery menu option. Everything should clear out and the plus gallery should come back. Now click on a gallery feed to go deeper and the thumbnails should slideUp then slideDown not allowing the user to see the thumbnails.

I feel this has to do with loading the gallery via Ajax and some variables are not clearing. Any guidance would be appreciated. Thank you very much.

jermartin77 commented 11 years ago

I think I know exactly what is going on. The click events are attaching multiple times. I have not implemented it on the same page twice and meant to try this out. I'll see if I can get some work done and then check this in. Watch it on gitHub or my twitter account if I don't fire off an email.

Thanks

Jeremiah

On Tue, Feb 26, 2013 at 4:32 PM, ArledgeMike notifications@github.comwrote:

Jer first off man, solid work. This plugin works flawlessly and elegantly on the most straightforward sites. I am having a small problem when I load the plus gallery using AJAX.

www.ychicago.com/projectwinters

To recreate the bug click on the "Gallery" menu option and panel will slide in and load the Plus Gallery.

Next click on another menu option. The panel should change content (please pardon the lack of animation is we are still in dev)

Next click back to the Gallery menu option. Everything should clear out and the plus gallery should come back. Now click on a gallery feed to go deeper and the thumbnails should slideUp then slideDown not allowing the user to see the thumbnails.

I feel this has to do with loading the gallery via Ajax and some variables are not clearing. Any guidance would be appreciated. Thank you very much.

— Reply to this email directly or view it on GitHubhttps://github.com/jermartin77/plusgallery/issues/6 .

ArledgeMike commented 11 years ago

Jeremiah

Thank you for your time and response. Look forward to seeing what you have. Thank you again for this plugin.

Best, Mike On Feb 26, 2013 10:31 PM, "Jeremiah Martin" notifications@github.com wrote:

I think I know exactly what is going on. The click events are attaching multiple times. I have not implemented it on the same page twice and meant to try this out. I'll see if I can get some work done and then check this in. Watch it on gitHub or my twitter account if I don't fire off an email.

Thanks

Jeremiah

On Tue, Feb 26, 2013 at 4:32 PM, ArledgeMike notifications@github.comwrote:

Jer first off man, solid work. This plugin works flawlessly and elegantly on the most straightforward sites. I am having a small problem when I load the plus gallery using AJAX.

www.ychicago.com/projectwinters

To recreate the bug click on the "Gallery" menu option and panel will slide in and load the Plus Gallery.

Next click on another menu option. The panel should change content (please pardon the lack of animation is we are still in dev)

Next click back to the Gallery menu option. Everything should clear out and the plus gallery should come back. Now click on a gallery feed to go deeper and the thumbnails should slideUp then slideDown not allowing the user to see the thumbnails.

I feel this has to do with loading the gallery via Ajax and some variables are not clearing. Any guidance would be appreciated. Thank you very much.

— Reply to this email directly or view it on GitHub< https://github.com/jermartin77/plusgallery/issues/6> .

— Reply to this email directly or view it on GitHubhttps://github.com/jermartin77/plusgallery/issues/6#issuecomment-14156536 .

jermartin77 commented 11 years ago

This should work I've committed some changes that allow loading of plusgallery with javascript. Still not support for multiple instances on the same page see demo called google-multiple.html (http://plusgallery.net/plusgallery/google-multiple.html).