search

jermbo / SampleAPIs

A simple, no fuss, no mess, no auth playground for learning RESTful or GraphQL APIs.
https://sampleapis.com/
MIT License
214 stars 54 forks source link

Beer API has incomplete entries / missing fields #123

Closed dave52 closed 3 years ago

dave52 commented 3 years ago

Hello -

Just wanted to call out that the Beer API has some missing fields, at the very bottom of the list: https://api.sampleapis.com/beers/ale

Specifically these id's: "id": 181, and "id": 182

Thank you for providing the APIs as a resource!

thedamian commented 3 years ago

Thank you so much for finding that @dave52 Do you know how to submit a PR (change) so this error can be fixed? It's super easy. Let us know if not and we'll be glad to help!

dave52 commented 3 years ago

I do, I did some minor detective work combing through the beers.json file: https://github.com/jermbo/SampleAPIs/blob/main/server/api/beers.json

...however wasn't able to find an "id": 181 or "id": 182, so not certain how those are being generated as additional objects into the endpoint.

thedamian commented 3 years ago

We are very appreciative of you finding those missing objects. I'm trying to encourage you to help the project out and get into the credits of this repo.

jermbo commented 3 years ago

@dave52 thanks for pointing these dull entries in the endpoint. I think this was just an oversight during clean up. We can either remove the items, or find 3 more to add there.

jermbo commented 3 years ago

After looking at the json files, it appears the two ids do not exist. The next server push will solve this issue. My guess is this was an artifact of someone trying to create entries but not passing in the rest of the information.