search

jermbo / SampleAPIs

A simple, no fuss, no mess, no auth playground for learning RESTful or GraphQL APIs.
https://sampleapis.com/
MIT License
214 stars 54 forks source link

added 1st mocha-chai test #92

Closed jonathans199 closed 4 years ago

jonathans199 commented 4 years ago

hey @jermbo I've added a mocha-chai testing, all passing properly, we could keep adding as needed.

might need to be implemented in the Pipeline when code is deployed to server @thedamian image

thedamian commented 4 years ago

I love the effort here and it's definitely better than what we have now. NOTHING.

Although we were thinking of a test that's more generic and would use the number of .json files to dynamically test ALL endpoints. Really all it would do is find all the .json and make sure there's endpoints for all and that the json files have a least one endpoint. (or collection)

So although this is a great first test (and we might want to just implement it to have something) I'd like to see something more generic.

As for when I deploy. I do it manually right now and so I could run a test but I'll also look into having a gitbot run all tests after any PR is submitted so it can write whether it passed (or failed) here in the notes.

jonathans199 commented 4 years ago

Sounds good @thedamian totally agree with you on having something more generic to loop over the current files and test each one.

But yes this is just a starting point that we could definitely build upon

And yes we should add a Github Action to deploy to your server and run the tests before the build as PRs get pushed to main.