search

jermp / fulgor

Fulgor is a fast and space-efficient colored de Bruijn graph index.
MIT License
44 stars 9 forks source link

Compilation error #17

Closed hsmurali closed 1 year ago

hsmurali commented 1 year ago

Screenshot 2023-09-12 at 1 48 18 PM

I get this error when I try to build fulgor. It works when I compile it with “-mpopcnt” flag. Would it be possible to make a commit with “-mpopcnt” flag in the CMakeLists.txt?

I am using FULGOR in one of my projects and it would be easier to integrate it into my pipeline if the flag was added to the CMakeLists.

Thank you.

jermp commented 1 year ago

Hi @hsmurali, sure, we're here to help. Where exactly did you add it? Did you add it here?

# Flags for PTHash:
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mbmi2 -msse4.2") # for hardware popcount and pdep

It's strange you got that error because the -msse4.2 should cover popcount.

hsmurali commented 1 year ago

Thank you. Yes that is where I added the -mpopcnt flag.

jermp commented 1 year ago

Ok, added. Can you test it on your end now to confirm it works correctly? For me, this works on both linux and mac os with x86.

Thanks!

hsmurali commented 1 year ago

Thanks, works fine now! I'll close the issue