search

jermp / pthash

Fast and compact minimal perfect hash functions in C++.
MIT License
179 stars 25 forks source link

duplicate hash values on additive displacement #42

Closed khodor14 closed 3 months ago

khodor14 commented 3 months ago

Hi,

I was using additive displcament in the play branch, however it is generating duplicate hash values.

You can download from here the keyset that I was using. The file I am using is kmers_64bits_5776.txt.

What could be the issue?

Best,

stefanfred commented 3 months ago

Thank you for reporting this issue. Should be fixed with #43

jermp commented 3 months ago

Hi, I also confirm it now works correctly. I tested it with:

 ./build -n 5775 -i kmers_64bits_5776.txt -l 12.0 -a 0.94 -e R-R -r add -b skew -s 1234567890 -t 2 --verbose -q 1000000 --check

Thanks @stefanfred for the fix!

Best, -Giulio

khodor14 commented 3 months ago

Hi,

@stefanfred @jermp thanks alot.

Best,