Added show parameter functionality

[limjohnny88]

Hello, my name is Johnny, and I'm from Singapore.

I can see that you have this interesting project and it is really helpful to all the developers out there and that is why I have decided to take a look at this project. It really works well but I think that more functionality can be added to this nifty tool, so I added a show parameter optional to this tool.

You can email me at limjohnny88@gmail.com if you have any questions.

Thanks

Regards Johnny

[jerodsanto]

Hi Johnny-

Thanks for the kinds words! Unfortunately, this pull request in its current state will not be accepted for a few reasons:

1) I'm not sure what you mean by "a show parameter option". Can you describe its usage and why people might want it? 2) You have modified almost every line of the code, making it very difficult for me to discern what your changes actually do. 3) You have changed all the code styling to fit your own aesthetic. When contributing to somebody else's open source project, it is common courtesy to adapt your coding style to fit to theirs. 4) Please don't modify any of the versioning information. I will always take care of that when I perform a release.

Thanks again and I look forward to hearing from you.

-Jerod

[limjohnny88]

Hi Jerod,

First of all thanks for the reply, I'm sorry for the mistake I made, as this is my first time contributing. :)

Basically, I have added an option in the console, where the user can choose to view the results from the auto-completion with the function having its parameter shown(the console will have a single column layout if the feature is on).

Function will show its parameter if the option is turn on http://i.imgur.com/8PXLb.jpg

Class will should its modifier and method + method parameter if the option is turn on http://i.imgur.com/jO6ja.jpg

Let me know if you like this idea and I'll refactor the files and resubmit to you.

Thanks

Regards Johnny

[jerodsanto]

Hi Johnny-

I think this feature is pretty cool and maybe it should just be the default. Regardless of that, please go ahead and clean up your branch and I'll take another look.

Thanks!

Jerod Santo http://jerodsanto.net

On Fri, Jul 1, 2011 at 9:45 AM, limjohnny88 < reply@reply.github.com>wrote:

Hi Jerod,

First of all thanks for the reply, I'm sorry for the mistake I made, as this is my first time contributing. :)

Basically, I have added an option in the console, where the user can choose to view the results from the auto-completion with the function having its parameter shown(the console will have a single column layout if the feature is on).

Function will show its parameter if the option is turn on http://i.imgur.com/8PXLb.jpg

Class will should its modifier and method + method parameter if the option is turn on http://i.imgur.com/jO6ja.jpg

Let me know if you like this idea and I'll refactor the files and resubmit to you.

Thanks

Regards Johnny

Reply to this email directly or view it on GitHub: https://github.com/sant0sk1/wordpress-console/pull/4#issuecomment-1483242