search

jeroen / V8

Embedded JavaScript Engine for R
https://cran.r-project.org/package=V8
Other
201 stars 29 forks source link

Need to load ICU data file on Fedora #65

Open jeroen opened 5 years ago

jeroen commented 5 years ago

Looks like Fedora 30 version of libv8 now also has a custom ICU so we to do something similar:

https://github.com/jeroen/V8/blob/6ac6e34d1d70ea24709179126866544cf714cf36/src/bindings.cpp#L36-L40

Bug report in dagitty: https://github.com/jtextor/dagitty/issues/24

jtextor commented 5 years ago

Minimal code example to make V8 crash in R on Fedora 30 without dagitty or other libraries:

V8::new_context()$eval("\"a\".localeCompare(\"b\")")

The same code works for me in nodejs on the same machine:

[root@fedora-2gb-nbg1-1 ~]# node
> "a".localeCompare("b")
-1
>
jeroen commented 5 years ago

Thanks that is very helpful!

jeroen commented 5 years ago

Here is the bug report in Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=1755114

jeroen commented 3 years ago

Still a problem if we build against v8-devel in Fedora 34 (but not with DOWNLOAD_STATIC_LIBV8).