search

jeroen / jsonlite

A Robust, High Performance JSON Parser and Generator for R
http://arxiv.org/abs/1403.2805
Other
376 stars 40 forks source link

Optimize nested lists #262

Open jeroen opened 6 years ago

jeroen commented 6 years ago

See the example here: https://twitter.com/layik/status/1052499262460841984

dcooley commented 4 years ago

perhaps this is resolved now? - https://gist.github.com/layik/9d20af29cbee934fd91d59a9f96dbe90#gistcomment-3321062

jeroen commented 4 years ago

I haven't really touched anything so I'm not sure how the benchmark has changed...

dcooley commented 4 years ago

perhaps R4.0 has had an unplanned benefit?

jeroen commented 4 years ago

I'm more suspicious of the benchmarking used here. Better use bench::mark to get a proper comparison.

dcooley commented 4 years ago

Turns out I had made a mistake and hand't use the correct object to start with - https://gist.github.com/layik/9d20af29cbee934fd91d59a9f96dbe90#gistcomment-3321944