search

jeroen / mongolite

Fast and Simple MongoDB Client for R
https://jeroen.github.io/mongolite/
286 stars 65 forks source link

Adds a public API for creating Object IDs #152

Open atheriel opened 6 years ago

atheriel commented 6 years ago

Inspired by #151 and some previous issues, this allows users to create OIDs that will be honored by mongo. I've also included an example and appropriate unit tests.

codecov-io commented 5 years ago

Codecov Report

Merging #152 into master will increase coverage by 0.11%. The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
+ Coverage   37.43%   37.54%   +0.11%     
==========================================
  Files         130      130              
  Lines       21904    21924      +20     
==========================================
+ Hits         8199     8232      +33     
+ Misses      13705    13692      -13
Impacted Files Coverage Δ
src/bson.c 60.71% <100%> (+3.02%) :arrow_up:
R/bson.R 28.57% <20%> (-4.77%) :arrow_down:
src/mongoc/mongoc-server-description.c 53.36% <0%> (+0.8%) :arrow_up:
src/mongoc/mongoc-topology-description.c 55.7% <0%> (+3.48%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 85b874c...8794fc7. Read the comment docs.

rparmm commented 9 months ago

What else is needed to merge this PR? I need this feature and can contribute to get this merged.