jeroen / mongolite

Fast and Simple MongoDB Client for R
https://jeroen.github.io/mongolite/
284 stars 64 forks source link

`stop_on_error` argument in `.$insert` #233

Open fmmattioni opened 2 years ago

fmmattioni commented 2 years ago

Hi!

I was having issues with the stop_on_error argument in .$insert. I have noticed that the function always stops on error actually. Perhaps it is because this was hard coded?

https://github.com/jeroen/mongolite/blob/1b769c63f0046e33a8156e22d2ac9a525bb05af7/R/mongo.R#L148

Thanks in advance!

fmmattioni commented 2 years ago

Ah, I just noticed this is actually setting the default.. so I wonder what the issue could be..