search

jeroen / mongolite

Fast and Simple MongoDB Client for R
https://jeroen.github.io/mongolite/
284 stars 64 forks source link

Fix -wformat warnings on Windows #242

Open jeroen opened 1 year ago

jeroen commented 1 year ago

CRAN started enfocring -wformat on Windows, which revealed some printf bugs in mongo-c-driver. See: https://www.r-project.org/nosvn/R.check/r-devel-windows-x86_64/mongolite-00check.html

@kevinAlbs

kevinAlbs commented 1 year ago

Thank you for the heads up @jeroen. Filed https://jira.mongodb.org/browse/CDRIVER-4484

jeroen commented 1 year ago

Can you also have a look at these -Wstrict-prototype warnings (i.e. missing void for functions without parameters)? These are going be problematic for C23: https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-clang/mongolite-00check.html

kevinAlbs commented 1 year ago

@jeroen is this blocking mongolite from being released on CRAN? That may help us determine how to schedule.

jeroen commented 1 year ago

We do need to fix these warnings if we want to push out a new release, But it's not super urgent because we don't have to do a mongolite release soon, there are no urgent problems afaik.

eramongodb commented 1 year ago

@jeroen Fixes have been merged in https://github.com/mongodb/mongo-c-driver/pull/1120. Please let us know if this commit resolved the issues reported.

jeroen commented 1 year ago

Thanks! That looks good.