search

jeroen / openssl

OpenSSL bindings for R
Other
63 stars 20 forks source link

Various cleanups #44

Closed agl closed 7 years ago

agl commented 7 years ago

I'm unsure whether there's was a specific reason to accept zero-length digests so I split the middle change out in case you don't wish to that that.

I am not especially familiar with R, but I have checked these changes using R CMD check openssl.

codecov-io commented 7 years ago

Codecov Report

Merging #44 into master will decrease coverage by 0.1%. The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   77.88%   77.77%   -0.11%     
==========================================
  Files          48       48              
  Lines        2035     2034       -1     
==========================================
- Hits         1585     1582       -3     
- Misses        450      452       +2
Impacted Files Coverage Δ
src/cert.c 57.14% <ø> (ø) :white_check_mark:
src/bignum.c 62.58% <ø> (ø) :white_check_mark:
src/base64.c 100% <ø> (ø) :white_check_mark:
src/rsa.c 100% <ø> (ø) :white_check_mark:
src/aes.c 79.41% <0%> (-4.97%) :x:
src/ssl.c 0% <0%> (ø) :white_check_mark:
src/keygen.c 100% <100%> (ø) :white_check_mark:
src/pkcs12.c 98.83% <100%> (ø) :white_check_mark:
src/keys.c 95% <100%> (ø) :white_check_mark:
src/openssh.c 83.96% <60%> (ø) :white_check_mark:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e05953...1b73eb3. Read the comment docs.

jeroen commented 7 years ago

Thanks! What brings you here if you're not an R user?