jeroenheijmans / advent-of-code-charts

Inject charts in your private leaderboard page for Advent of Code
MIT License
118 stars 21 forks source link

Days won't show up in tables and some charts if no member has completed part 2 yet #100

Open AlexandraDorey opened 6 months ago

AlexandraDorey commented 6 months ago

Note javascript is not really a lang I do a lot of dev in and I skimmed the code for anything obvious but couldn't see much. We have a situation where nobody has managed to get the 2nd start for day 21 yet on our leader board, and as a result no stats seem to be showing up for that day, looking through the code there are a couple places it looks like you loop on the count of the 'a' medals so if that collection is zero it's plausible nothing would happen? That's my best guess, anyway if you have a chance to look at it that'd be awesome, and Thanks for the great addon :)

jeroenheijmans commented 6 months ago

Hi there, and thanks for taking the time to write up an issue!

I think you're right. Days where no Leaderboard Member has completed 2 stars yet, will be excluded from most portions of the addon. At the least the medals overview and delta times work this way. There were a few 2023 days already where I noticed the same on my company's leaderboard 😅

Originally this was intentional, but I think it's better to change this if possible.

It is likely that fixes for this will come only after Dec 2023, between work, completing the puzzles myself, and finishing up the AoC Survey Results, I don't think there's room to fix it this year. Hope that makes sense!

Happy puzzling either way!

leyanlo commented 6 months ago

+1. Day 21 was (continues to be) brutal 🙃