search

jeroenheijmans / advent-of-code-charts

Inject charts in your private leaderboard page for Advent of Code
MIT License
118 stars 21 forks source link

Minutes Per Star for all players #62

Closed rioj7 closed 1 year ago

rioj7 commented 2 years ago

In the Minutes Per Star chart only the top 3 player where shown.

It is not possible to compare your times with any other player.

Now depending of Responsive it shows the top 5 (2 hidden) or all players (n-3 hidden).

There is a problem with the legenda of ChartJS, With many players the legenda goes outside the chart drawing (top-bottom) and then these legenda parts are not clickable (toggle hidden). I will make a test program and an issue at ChartJS repo. It make a second column of users but also draw a few users in the first column on the wrong spot.

jeroenheijmans commented 2 years ago

Thanks for the suggestion! Not sure yet what direction I'll go with this, there's a trade off here. I've not been able to look at it in this year anymore (partly because my time went into the survey) but I'll revisit the suggestion hopefully around November 2022, before the next edition!

jeroenheijmans commented 1 year ago

I apologize @rioj7: my intention truly was to look at this in November already, but life happened this fall, so no big updates to the repo or extensions this year I'm afraid. I do appreciate the submission though and hope to get to it after this AoC'22 at some point. Hope you understand!

jeroenheijmans commented 1 year ago

Took some time to check this for #79 (2023 updates) and this looks like a great addition to me! I'll extend the 5 to 8 shown in responsive mode I think that'll still work.

I'll merge this into the 2023 branch.

PS. On a whole, I'm not sure if this graph will stay forever, but until it does this is a solid improvement!