search

jeroenheijmans / advent-of-code-charts

Inject charts in your private leaderboard page for Advent of Code
MIT License
118 stars 21 forks source link

Localised Time #71

Closed ogoletti closed 1 year ago

ogoletti commented 1 year ago

Not sure if I missed it, but would it be possible to have localised time in the "Time" columns.

jeroenheijmans commented 1 year ago

Can you elaborate? Are you talking about this table?

part 1, delta, and part 2 times

Because that doesn't show "Time of Day" but "Time Taken" (so a "timespan"), which is the same regardless of your locale.

ogoletti commented 1 year ago

Time spent since the release of the puzzle (so basically UTC-5) if I'm not mistaken. It kind of translate to a time of the day somehow. And as such could be more readable if localised.

jeroenheijmans commented 1 year ago

Hmmm, I see your point, but it really is intended to be "Time since puzzle was released" (which indeed happens to be midnight UTC-5), similar to how "Time" is used as a term on the personal stats page.

I understand it can be confusing if leaderboards and "time taken" are not top of mind, or if you have a leaderboard where everyone "agrees" to start at some other point in time it might also be different; then a localized variant might be useful. Just not sure if I want to add toggles or settings (making things more complex) to cater for every type of context.

Put differently: for me, and for many others too I presume, the "time taken since released" interpretation is the reasonable default.

Will let your question/suggestion sink in a bit more though. (And either way: thanks for taking the time to write your feedback!)

ogoletti commented 1 year ago

No worries. It isn't really necessary. We don't care about time anyway. I found your plugin because I wanted to be able to sort on "delta time" anyway. Then I thought it'd be more readable (for me) if the "Time" column actually meant anything to me... But I hadn't realised at that moment that it actually was "Time" since release intedended for competitive players. (Do you really wake up at 6AM for the puzzles?)

jeroenheijmans commented 1 year ago

Haha :D indeed I live in West-EU and get up 05:50 at least for the first few days. This year's hectic for me personally so not sure if I'll keep it up for too long 😂

The "Delta Time" is the main reason for that table to be there too by the way. It gives some way of comparing performance against friends and colleagues, in a manner neutral to what time you start puzzling.

I'll leave the issue open and give it a bit more thought, but might indeed close it later.

Glad the plugin was helpful regardless, and: happy puzzling! :)

jeroenheijmans commented 1 year ago

I was considering this for #79 (2023) but I think I will stick with the existing situation, where "Time" means "time taken" regardless of time zone. This is consistent with how the AoC website does things e.g. on The Personal Stats page. Hope that makes sense.

Thanks for taking the time to provide feedback!