search

jeroenheijmans / advent-of-code-charts

Inject charts in your private leaderboard page for Advent of Code
MIT License
120 stars 21 forks source link

Safari extension port #74

Open fred-corp opened 1 year ago

fred-corp commented 1 year ago

First of all, thanks for this amazing extension ! I've managed to create a safari port with the following Apple Developper command :

xcrun safari-web-extension-converter ./build

The extension seems to work fine on iOS, iPadOS macOS; If you want I can create a pull request with the added Xcode Project files

Best regards, Frédéric Duppel

leyanlo commented 1 year ago

Whoa so cool I can put this on my phone now. Had no idea this was so easy

tenhobi commented 1 year ago

Very cool. There I found a step-by-step of how to enable that extension in Safari. 🙏 https://www.vshsolutions.com/blogs/convert-chrome-extension-to-safari-web-extension/

fred-corp commented 1 year ago

Created Pull request #75 for Xcode source files & Safari macOS app

jeroenheijmans commented 1 year ago

Thx @fred-corp for suggesting this, and good to hear you enjoy the extension!

The PR worries me a bit and I'm not sure what to do with it yet. It adds/changes a whopping 82 files, including all sorts of binaries, duplications of other files in the repo, and other files.

What also doesn't help: I don't currently have access to a Mac (only an iPad) so no good way to maintain an Apple-only part of the code-base.

On the other hand it is super cool that it works across Apple devices including tablet and smartphones.

Would you be okay to let the PR and issue sit for (quite) some time? As announced in #69 my personal and work schedule around this December is absolutely insane, and I have no real time to do anything besides crucial fixes.

Regardless: thanks for sharing! And: happy puzzling!

fred-corp commented 1 year ago

Hi @jeroenheijmans Thanks for checking out the PR :)

I completely understand that the way I added the code is not optimal; I did it this way so other people could maybe install the extension on their device more easily.
I'll try to experiment with file linking in Xcode, and maybe try to find a way to automate the app building with GitHub workflows

jeroenheijmans commented 1 year ago

Cheers! And again: thanks for sharing.

It's most welcome if you already research how the PR could be changed, though I will in the end still need to consider maintenance effort as well. (But in essence I'd love to have support for an additional browser of course :) - it's a shame Safari doesn't support the standardized way for extensions 😢)