search

jeroenheijmans / advent-of-code-charts

Inject charts in your private leaderboard page for Advent of Code
MIT License
120 stars 21 forks source link

Improve "thick line for logged in user" feature #86

Closed jeroenheijmans closed 1 year ago

jeroenheijmans commented 1 year ago

With v6.0.0 a feature to detect the "Logged In User" was added. It is used to make "your own" line in graphs stand out more. It was pointed out on Reddit that this is a bit much, especially for (very) small leaderboards.

The suggestion there was also made to make it a toggle/setting. That's certainly a viable option.

I'd like to consider alternatives too (e.g. making the thickness a bit less so, and/or doing it only for large leaderboards), because "yet another setting" also has a cost attached (for UX, and for maintenance).

To be decided how to proceed, but for sure something to tweak.

See #79.

jeroenheijmans commented 1 year ago

I've decided not to introduce a 'toggle' for this, because I dislike apps with too many settings. Instead, I've strongly reduced the effect of extra thickness, so we can serve both cases.

For large leaderboards only that little bit is needed now anyways as the alpha is also lowered for others:

image

And for the redditor's question with smaller leaderboard, "your" line is now only a wee bit thicker so not as obtrusive anymore:

image

I know that last one doesn't fully 'solve' the request to be able to toggle it to regular mode, but I really want to avoid having a ton of toggles in the app. Hope that makes sense.

Commit and plugin update forthcoming.

SuperTux88 commented 1 year ago

Yes, I agree that too many options aren't necessarily better. As a user I like to have many options, but as a dev I also know it's not easy to add many options with good UX so non-power-users don't get overwhelmed. And that's also why I wasn't really sure if I should even ask for it, as I also didn't really have a good solution for it. But the thinner-by-default line now works quite well. it's still pretty visible on crowded leaderboards, but also works ok-ish on smaller leaderboards. :+1: I still have one leaderboard where I was racing with another person and we were pretty close for multiple days, but the new percentage view also already improves the visibility with close lines and it's visible as soon as we are 2 or more points apart. So probably good enough.

I just had another idea: what if the highlighted line is done with hovering over the names/lines? That could help to also quickly highlight other lines in a big board (without needing to disable everybody else). But I also don't know how easy that is and what it does to performance on big boards? :thinking: So not sure if it's worth it, but if you think it is doable and could be useful, I can create a separate issue about it.

But the new version already solves my issue good enough, so thanks for the quick update :heart: Everything else is really just "nice to have" territory.

jeroenheijmans commented 1 year ago

Thx for your reply and extra thoughts! I've taken the liberty of writing up #88 with your input. I think I will let that sit for some time, at the least until I know if a 2023 edition of AoC is gonna happen.