search

jeroenjanssens / data-science-at-the-command-line

Data Science at the Command Line
https://datascienceatthecommandline.com
Other
3.78k stars 766 forks source link

Wrong return code #51

Closed tonyfischetti closed 8 years ago

tonyfischetti commented 8 years ago

There are some places that return a non-successful error code (anything but 0) when there's no error. For example, https://github.com/jeroenjanssens/data-science-at-the-command-line/blob/master/tools/header#L65

This is a big problem because some interprocess communication tools fail because they depend on a successful exit status. Should I submit a pull-request?

jeroenjanssens commented 8 years ago

Ouch! Thanks for catching that @tonyfischetti. A pull-request would be great.