jeroennoten / Laravel-AdminLTE

Easy AdminLTE integration with Laravel
MIT License
3.78k stars 1.08k forks source link

Add Laravel 11 support on tests #1261

Closed dfsmania closed 3 months ago

dfsmania commented 4 months ago
Question Answer
Issue or Enhancement Enhancement
License MIT

What's in this PR?

Checklist

dfsmania commented 4 months ago

[!Caution] Again facing problems with uploading coverage to scrutinizer....

Logic that involves downloading ocular.phar do not work:

wget https://scrutinizer-ci.com/ocular.phar
php ocular.phar code-coverage:upload --format=php-clover coverage.clover

This gives the same error we faced before:

[Guzzle\Common\Exception\InvalidArgumentException]  
Invalid handle provided 

Also, we can't use the scrutinizer/ocular dev dependency when testing on Laravel 11. because there's a conflict of package requirements with ocular. So, the only workaround we can use for now, is to keep uploading coverage for Laravel 10.X version, but removing scrutinizer/ocular from the dev dependencies and require it with composer when uploading the coverage.