Improve menu filters (last stage) - Githubissues

jeroennoten / Laravel-AdminLTE

Easy AdminLTE integration with Laravel

MIT License

3.78k stars 1.08k forks source link

Improve menu filters (last stage) #1274

Closed dfsmania closed 2 months ago

dfsmania commented 2 months ago

Question	Answer
Pull request type	ENHANCEMENT
License	MIT

What's in this PR?

Improve the ActiveChecker class:

Internal UrlGenerator instance was removed, instead url() helper from Laravel is used now.
Internal Request instance was removed, instead request() helper from Laravel is used now.
Improve the logic of the class.

Improve the HrefFilter class:

Internal UrlGenerator instance was removed, instead url() helper from Laravel is used now.
Improve the internal filter logic.

Tests were modified to adapt to the previous improvements:

The HrefFilter tests were separated into a different test class.
Since the ActiveChecker and HrefFilter constructor methods were changed, most of the test were adapted.

Checklist

[x] I tested these changes.