Improve CommandHelper class - Githubissues

jeroennoten / Laravel-AdminLTE

Easy AdminLTE integration with Laravel

MIT License

3.78k stars 1.08k forks source link

Improve CommandHelper class #1283

Closed dfsmania closed 1 month ago

dfsmania commented 1 month ago

Question	Answer
Pull request type	ENHANCEMENT
License	MIT

What's in this PR?

Replace own implementation of EnsureDirectoryExists() by the one provided by the File facade.
Replace own implementation of removeDirectory() by the one provided by the File facade.
Improve logic on copyDirectories(), now returns a boolean when failing. Scrutinizer rating is also improved.
Improve logic on compareDirectories(). Scrutinizer rating is also improved.
Improve testing over this class.

Checklist

[x] I tested these changes.