search

jeroenpardon / skin.grid

Grid, a UI for Kodi. By using this code you agree with the license terms as included.
http://www.gridskin.net
Other
39 stars 25 forks source link

[WIP] DialogVideoInfo: support ratings flags #118

Closed RealJohnGalt closed 7 years ago

RealJohnGalt commented 7 years ago

This might need font changes, color changes, icon changes, size changes, and positioning changes. Additionally, I'm not sure if only labels (no images) would be better. Icons taken from fuse(neue).

Screenshot: http://i.imgur.com/zAYxjhH.jpg

RealJohnGalt commented 7 years ago

I think labels instead of icons look best here, but this might need a font change still, or separate grouplists for different spacing. Personally, I think it looks best if the ratings don't exceed the button group width.

Screenshot with labels instead of icons: http://i.imgur.com/bJxp2vw.jpg

jeroenpardon commented 7 years ago

There's a couple of issue I have with this.

Mostly, I find it removes the visual balance of this window. There's a clear visual distinction with the info blocks, plot and button row. I guess it feels "bolted on" this way, no disrespect intended.

Apart from that I don't like yet another skin toggle and the forced choice between two unrelated bits of info (ratings and path). If i create a toggle for something it will be for more or less interchangeable or at least related bits of info.

To be honest I don't find external ratings all that important or relevant, showing 4 at a time is overkill to me.

There's also no user ratings, which is the only rating I truly find relevant.

So I'm sorry, but I will not be merging this.

RealJohnGalt commented 7 years ago

I understand. It does look "bolted on," though I think font and spacing changes may help with that.

I've become accustomed to ratings since I regularly get movies added I know nothing about. I also find path useless (and often ugly) so will keep using it personally.