search

jeroenpardon / skin.grid

Grid, a UI for Kodi. By using this code you agree with the license terms as included.
http://www.gridskin.net
Other
39 stars 25 forks source link

animated artwork as condition for text labels #141

Closed Joostzilla closed 7 years ago

Joostzilla commented 7 years ago

In Movies landscape view some fanart have the title shown by Grid while others have not. If the fanart does not have the movies title as part of the fanart it is hard to see which movie it is.

image

jeroenpardon commented 7 years ago

It all depends on what your landscape artwork type is set to and whether you have logo's enabled.

Artwork type set to prefer landscape thumbnails

Artwork type set to prefer fanart

Joostzilla commented 7 years ago

That's clear. What an options 👍 I will have to get used to the power of Kodi. Since i prefer Landscape thumbnail i now have logo's enabled. Does this add text based titles as fallback when no landscape or logo is available?

Joostzilla commented 7 years ago

I found out that the text based titles do not appear on Animated art.

jeroenpardon commented 7 years ago

Hm, right. That would be a oversight :)

jeroenpardon commented 7 years ago

Since i prefer Landscape thumbnail i now have logo's enabled. Does this add text based titles as fallback when no landscape or logo is available?

It should yes.

Joostzilla commented 7 years ago

But it does not yet ;-)

jeroenpardon commented 7 years ago

I was doubting myself when posting ;P So I just checked the code, and logos are basically not a factor currently when the artwork is set to landscape. The fallback routine is landscape images > fanart + text title

It might seem a trivial thing, but the way it currently is is already quite complex. I think in most cases a landscape image will be available so I'm not looking to increase the complexity here (note though that you may not get landscape artwork currently because of issues with the artwork downloader add-on.

Joostzilla commented 7 years ago

For me its no problem. Most movies have landscape thumbs or animated art. Since i manage my media with TinyMediaManager and use Plex it already has 99% of the art available in the media folders. And i am still trying to figure out which view i prefer for browsing for movies. Which do you use?

jeroenpardon commented 7 years ago

I found out that the text based titles do not appear on Animated art.

I just checked this, but with animated artwork turned on, I am seeing text based titles? Is this in particular viewtypes for you?

And i am still trying to figure out which view i prefer for browsing for movies. Which do you use?

For movies it's pretty much list view all the way with the exception of the recently added movies node and watchlist where I use Gallery and Big List.

Joostzilla commented 7 years ago

Okay, what i found out i this: (all in landscape view)

Turning off Animated Art isn't possible on a global scale. Is it?

jeroenpardon commented 7 years ago

Yeah, so that basically works as intended, if animated fanart is not taking into account. I think it should be doable to create an exception rule based on whether or not animated artwork is being displayed. I think...will have to look into it.

Turning off Animated Art isn't possible on a global scale. Is it?

You mean, not showing it at all? Sure, it's an optional feature.

Joostzilla commented 7 years ago

You mean, not showing it at all? Sure, it's an optional feature.

Really, where do i find the option?

jeroenpardon commented 7 years ago

Skin Settings -> Visual effects

But I'm pretty sure it's off by default ;)

Joostzilla commented 7 years ago

Skin Settings -> Visual effects But I'm pretty sure it's off by default ;)

Of course i knew it was there. Somehow i thought it was for homescreen only. Blackout ;-)

jeroenpardon commented 7 years ago

Closing this. Before delving into this further let's see if animated artwork is even a lasting thing.