search

jeroenpardon / skin.grid

Grid, a UI for Kodi. By using this code you agree with the license terms as included.
http://www.gridskin.net
Other
39 stars 25 forks source link

Missing translation #2 #158

Closed Ostrymiecz closed 6 years ago

Ostrymiecz commented 6 years ago

Now this report is a bit tricky and for now rather more of a question. Check this line: https://github.com/jeroenpardon/skin.grid/blob/master/xml/Includes_Menu.xml#L134 and tell me where can I find strings for those labels which are view modes names. If they aren't in Grid's language file, they must be in Kodi's one, but which? I cannot find them.

Will You help Jeroen? One of them isn't translated at all to Polish and other ones are translated so-so.

And BTW – why not add them to own Grid's translation file? Relying on some other strings which are used somewhere else feels wrong to me. Surely You can use common and simple words as Yes, No, File etc. but those view modes need special treatment.

jeroenpardon commented 6 years ago

That is not a single string, it's an infolabel which uses different strings depending on what is selected. It is directly related to a Kodi function meaning I can't just simply replace it. And if I would want to replace it, that would mean adding dozens of lines just to display one string. Doing that instead of improving or adding the Kodi core string(s) is totally backward to me.

Strings are only added when Kodi's source file doesn't provide them.

Ostrymiecz commented 6 years ago

So can You tell me where can I find the original ones?

jeroenpardon commented 6 years ago

From Kodi core: 535,536

There might be more, as the viewtype labels are set through a parameter, in some situations other ones might be used, but these are the ones I could trace quickly. These labels have been used for years though.

The rest is in Grid's strings (note though that these labels may be used elsewhere too) msgctxt "#31200" msgid "Posters" msgstr ""

msgctxt "#31201" msgid "Portrait" msgstr ""

msgctxt "#31202" msgid "Landscape" msgstr ""

msgctxt "#31203" msgid "Thumbnails" msgstr ""

msgctxt "#31204" msgid "Logos" msgstr ""

Ostrymiecz commented 6 years ago

Thanks! I'm looking for the "Gallery" viewtype beacuse it isn't translated to Polish at all. I was searching thru Kodi core and found nothing :(

jeroenpardon commented 6 years ago

Gallery is in Grid's strings

Ostrymiecz commented 6 years ago

Now this is strange. There is such string but Kodi/Grid shows English string, not Polish one.

Ostrymiecz commented 6 years ago

Proof: https://youtu.be/Ccnsh2KEbbU

FrissonReynald commented 6 years ago

Hello, sorry for my absence I had some problems that took all my time. : (