jeroenpardon / skin.grid

Grid, a UI for Kodi. By using this code you agree with the license terms as included.
http://www.gridskin.net
Other
39 stars 25 forks source link

Horizontal menu bug? #160

Closed Ostrymiecz closed 6 years ago

Ostrymiecz commented 6 years ago

I'm using latest Grid "beta" from this repo and after recent update (when Hubs were introduced) something went wrong with horizontal menu.

When I hover System menu and press down arrow to go to the submenu, whole menu slides up to middle of screen rather than just switch to submenu. It should be like this?

Tried resetting menu to default but that didn't helped.

jeroenpardon commented 6 years ago

Can't reproduce this, tried with and without widgets enabled. Home menu code hasn't seen any changes in recent updates, so not sure what could be causing it tbh

Ostrymiecz commented 6 years ago

So I must try resetting all settings to default.

jeroenpardon commented 6 years ago

Any luck with narrowing this one down?

Ostrymiecz commented 6 years ago

No 😒 I've even downgraded Colorbox add-on and no luck at all. Give me just a moment and I will record short video to show You this weird behavior. Maybe I wrote this ticket badly in first post.

Hold on…

Ostrymiecz commented 6 years ago

See this video Jeroen: https://youtu.be/biGUMY4JJXM

Ostrymiecz commented 6 years ago

Any ideas what went wrong Jeroen?

Ostrymiecz commented 6 years ago

I just tested it once again and:

  1. Removed Grid add-on from Kodi
  2. Removed all skin.grid* directories from HDD
  3. Reinstalled Grid v1.5.1 from official repo

and bug still exists. WTF?!?

jeroenpardon commented 6 years ago

So it happens on the system submenu only? Looks like as if there is a widget on that menu item that can't be loaded or something. Try clearing out %kodiprofile%\userdata\addon_data\script.skinshortcuts

warning: this will remove any home menu customizations

Ostrymiecz commented 6 years ago

Currently it happens only on system submenu because it's my only submenu. I'll try clearing out mentioned folder and also adding other submenus.

Ostrymiecz commented 6 years ago

Just tested it:

  1. Added other sumbenu and it's the same.
  2. Cleared out %kodiprofile%\userdata\addon_data\script.skinshortcuts folder and booted Kodi. Menu was recreated and still same bug.

Can we somehow debug why is Kodi sliding this menu upwards?

Ostrymiecz commented 6 years ago

Don't know if it's important but after the menu slides up and you're in submenu (so submenu item is "hovered") there is something like third bar beneath submenu.

jeroenpardon commented 6 years ago

There's a file called script-skinshortcuts-includes.xml in the skin's xml folder, can you upload that?

Ostrymiecz commented 6 years ago

Yes, but as soon as I get back home after work. This bug is super weird.

About script-skinshortcuts-includes.xml file. Shouldn't this file be fresh or created/recreated while I was installing fresh Grid? Because I did fresh skin install and it didn't helped. And yes I cleared all Grid's folders in Kodi dir and profile dir.

Ostrymiecz commented 6 years ago

Here it is script-skinshortcuts-includes.zip

Ostrymiecz commented 6 years ago

And here's a screenshot with debug info on main screen. screen

jeroenpardon commented 6 years ago

yeah the debug info doesn't really say anything about the home menu. I will look into this further once I get the chance, available time is very limited atm.

Ostrymiecz commented 6 years ago

When submenu scrolls whole menu to the middle of the screen debug info stays the same. So, yeah, it doesn't help in this case.

Ostrymiecz commented 6 years ago

Notice something like a third row (marked in red) under a submenu. Don't know if it should be there or not.
screenshot000

Also I think that this must be somehow "controlled" because menu smoothly slides up on screen. So some animation is applied there. And this must be controlled by some XML I guess?

hoppel118 commented 6 years ago

I am in the same situation. I am using the horizontal menu and when I press the down arrow to go to the submenu, the whole menu slides up into the middle of the screen. But I thought this is the default per design. I prefer it this way really. It makes the skin more dynamic.

screen shot 2018-03-05 at 22 39 12

screen shot 2018-03-05 at 22 39 20

Greetings Hoppel

jeroenpardon commented 6 years ago

now that part of the horizontal menu structure has been reworked I am assuming this is not an issue anymore?

Ostrymiecz commented 6 years ago

Woohoo! Grid 1.6.0 fixes this issue. Yay! πŸ‘

jeroenpardon commented 6 years ago

πŸ‘