jeroenpardon / skin.grid

Grid, a UI for Kodi. By using this code you agree with the license terms as included.
http://www.gridskin.net
Other
39 stars 25 forks source link

Request: OSD playback progress indicator when pressing "enter" in addition to showing the menu #163

Closed olavinto closed 6 years ago

olavinto commented 6 years ago

Description

The OSD is one of the cleanest I've seen but it would be nice to see progress simply by clicking "enter" (or "select" or whatever term is the correct one?). How about showing the same bar that is shown at the top when "Movie/Episode information" is selected from the OSD menu or when playback is paused? I know that this is a small thing but it would be nice to check out where one is in the video a) without pausing and b) without having to make an additional menu selection.

Here's why I can't use the "Movie/Episode information" selection ("info" command or "i") directly (in case you were wondering): I mainly use a Logitech Harmony remote (via Bluetooth) to control playback and with that my control options are limited to mostly direction, ok/select, back and standard playback controls and a full sized keyboard is not available (or at least is not practical to use) when I'm using Kodi 'on the couch'. This means that with most skins checking playback position (without pausing) is easy by hitting "ok" and then "back" (usually OSD's show the progress bar and time here). The remote should be MCE remote compatible but the "info" button (which would be great for the info OSD), for some reason acts like "right arrow" button does (in Windows 10 it does at least) and while some of the remotes commands can be edited it is not possible to select letters as commands for the Bluetooth device (most likely because they are reserved for the keyboard part of the Harmony's functionality- which is available as a separate keyboard or in the mobile app) and because of this I can't edit the "info" button to send "i" command and have to stick with whatever the default operation for the MCE remote's "info" command is. Otherwise I would be very happy to just hit the "info" button to check playback status but currently I can't and it is not by any means the fault of GRiD.

Reproduction

Checklist:

jeroenpardon commented 6 years ago

The OSD is really meant as a way to access playback functions and settings rather than showing media information. That said though, showing the progress bar might be easy to do though. If it is, I'll look into providing an option for it.

You should definitely be able to use your Harmony for this though. I uses several Harmony remotes with Kodi and the Info function is mapped to the info button on my remote. I am using a Flirc though (www.flirc.tv), but that should be no requirement.

olavinto commented 6 years ago

I don't know why the info button does not act as it should. It is mapped as info but it acts like right arrow would. I remember that it used to work fine but this was a long time ago, maybe something like 2+ years ago, possibly it with an older Windows 7 system where I had IR too. If I could use IR to send commands to my PC, than I'd have a lot more options and could even teach the remote but because I use Bluetooth it is limited to the normal MCE commands the Harmony software offers. I have the Harmony Ultimate and the PC is controlled via the Hub which connects to the PC via Bluetooth. I also use Unified Remote for broader control like occasional mouse/keyboard usage but touch screen control is not that great for casual media control because it generally requires eye contact with the remote. This info button problem might be a bug in Logitech's software/firmware and possibly Bluetooth specific. Who knows. I will send a message their way too.

jeroenpardon commented 6 years ago

Ah yeah missing IR is probably the limitation here. I am using the Harmony Companion with the Hub. A flirc could give you the IR functionality. I can really recommend them. I have two of them and they work perfectly.

jeroenpardon commented 6 years ago

Commit 88d7021db842e26e0b00041670c21bd22204d8c6 should take care of this request. If you grab the latest Krypton build from Github you can try it out. Look for the option in Skin Settings > Information > OSD.

olavinto commented 6 years ago

Looks just as I imagined it (not that it required a huge amount of imagination...). I thank you very much, sir!

My computer is quite far away from the actual media center/living room and hooked up to there with a long 8m HDMI cable. So USB/IR would require some cabling and stuff. I have one Antec Veris (Soundraph iMON) thing available though so that could work if I can find working drivers for Windows 10.

jeroenpardon commented 6 years ago

You're welcome, closing this of now. Should you run into any issue with it just find it under closed issues and comment.