jeroenpardon / skin.grid

Grid, a UI for Kodi. By using this code you agree with the license terms as included.
http://www.gridskin.net
Other
39 stars 25 forks source link

Watched indicators - recordings and storage capacity. #40

Closed loggio closed 7 years ago

loggio commented 7 years ago

I know PVR provably drives you nuts so I do apologise.

I'm happy you've fixed the channel logo thumbs overlapping the watched indicators in recordings, but can we get some watched indicators for recordings? Even if this means getting rid of the logo thumbs and using indicators instead as they're probably more important.

Also, some skins show the storage capacity information for the recordings folder (total space/used space) so we can see how much storage we have left. Is there anywhere we can fit this in the window?

jeroenpardon commented 7 years ago

Yes, unwatched indicators still need to be added here, haven't made my mind up about how yet. Indeed because of the channel icons being there. Because of the channel icons I already moved timer & recording indicators to the right side of the list in the channels list. I don't mind the inconsistency there that much as these indicators are different from the unwatched indicators in movies for example. But moving the "normal" indicators to the right looks weird to me.. So does moving the channel icons esewhere. I guess I would be tempted to keep the channel icons out here. Maybe make the channel icon an overlay on the thumbnail on the right?

Tried something regarding the storage capacity in fe93853de1a92ce3cc4b9e37ede2b28009c13718 let me know what you think (see menu). Can't think of any other places atm where it wouldn't look out of place. Would look ok in the upper right beside the time, but that space is already shared between date, playing media, notifications, progress indicators so that's not really practical.

loggio commented 7 years ago

The channels overlay on the thumbnail sounds like a good compromise here.... shouldn't clutter the design at all. If that doesn't work out so well, you could always remove the logos all together. The channel name is already present in the list as a label in the time/date field below the program title anyways.

jeroenpardon commented 7 years ago

Apart from the goof in #47 these should be taken care of now, so closing