jeroenpeeters / docker-ssh

SSH Server for Docker containers ~ Because every container should be accessible
GNU General Public License v2.0
641 stars 88 forks source link

Why is container deprecated #47

Open DaanBiesterbos opened 6 years ago

DaanBiesterbos commented 6 years ago

Hi :-)

Thanks for this useful library.

I would like to ask why the container parameter is deprecated? It seems to make more sense to use "container" especially when using docker-compose. I don't see how adding json to an environment variable improves anything while the container property is straight forward, easy to use and works like a charm. The same can't be said about the filters property. When I try to use the value from the examples I get "Invalid interpolation format" errors. There should be a solution for it but still..... Container does give a headache. I am a big fan of "container".

Kind regards, Daan