jeroenterheerdt / HAsmartirrigation

Smart Irrigation custom component for Home Assistant
MIT License
308 stars 48 forks source link

[REQ] No translation for help #223

Closed gatonero closed 9 months ago

gatonero commented 9 months ago

Is your feature request related to a problem? Please describe. see title

Describe the solution you'd like Add translation

Describe alternatives you've considered

Additional context grafik

jeroenterheerdt commented 9 months ago

What part? Hilfe is translated?

gatonero commented 9 months ago

But all the text below is English.

jeroenterheerdt commented 9 months ago

Yes, got it

jeroenterheerdt commented 9 months ago

Assiging to you to update de language file. Latest beta introduces localized strings for this (see en language file)

jeroenterheerdt commented 9 months ago

Added in https://github.com/jeroenterheerdt/HAsmartirrigation/releases/tag/v2023.9.0-beta8. Please update de language file. Also tagging French language owner @diyanei and Italian language owner @valerix85 so they can eventually update their respective languages as well.

gatonero commented 9 months ago

I added the fields but I don't see the translation. Same as #222

Maybe the reason is https://github.com/jeroenterheerdt/HAsmartirrigation/actions/runs/6071509851

jeroenterheerdt commented 9 months ago

I changed my UI to German and see this: image

So looks good to me, not sure what is going on on your end though.

gatonero commented 9 months ago

Very Weird. I have three installations.

  1. A virtual machine on Proxmox. Productive system
  2. A virtual machine on Proxmox, for testing purposes
  3. A supervised Installation on my PC, for testing purposes

On each machine I installed v2023.9.0-beta10. I don't see this change. It's still in English when I switch to German. When I switch to the new languages Italian, French and Spanish on all machines All I see is English.

I will close #222 because it's seems to be the same reason.

gatonero commented 9 months ago

In /frontend/localize.ts I found following:

grafik

The explanation is:

Cannot find module 'intl-messageformat' or its corresponding type declarations.ts(2307)

jeroenterheerdt commented 9 months ago

In /frontend/localize.ts I found following:

grafik

The explanation is:

Cannot find module 'intl-messageformat' or its corresponding type declarations.ts(2307)

That is normal if you just opened the file or are you in de dev container when this happens?

gatonero commented 9 months ago

I'm in HAOS

Home Assistant 2023.8.4 Supervisor 2023.08.1 Operating System 10.5 Frontend 20230802.1 - latest

jeroenterheerdt commented 9 months ago

Yeah, so no dev container. I still think this is a browser / cache issue. Have you tried another browser? Clearing your browsers cache?

gatonero commented 9 months ago

Firefox, Vivaldi and Companion App. All caches deleted an restarted. Don't know what else. Also I don't see the new languages, it's all English for them.

gatonero commented 9 months ago

When I push something to the repository I'm getting following since days:

Integration smart_irrigation - /github/workspace/custom_components/smart_irrigation:
Error: R] [SERVICES] Service reset_bucket has no name and is not in the translations file
Error: R] [SERVICES] Service set_bucket has no name and is not in the translations file
Error: R] [SERVICES] Service set_bucket has a field value with no name and is not in the translations file
Error: R] [SERVICES] Service calculate_hourly_adjusted_run_time has no name and is not in the translations file
Error: R] [SERVICES] Service calculate_daily_adjusted_run_time has no name and is not in the translations file
Error: R] [SERVICES] Service enable_force_mode has no name and is not in the translations file
Error: R] [SERVICES] Service disable_force_mode has no name and is not in the translations file
Warning: G] [CONFIG_SCHEMA] Integrations which implement 'async_setup' or 'setup' must define either 'CONFIG_SCHEMA', 'PLATFORM_SCHEMA' or 'PLATFORM_SCHEMA_BASE'. If the integration has no configuration parameters, can only be set up from platforms or can only be set up from config entries, one of the helpers cv.empty_config_schema, cv.platform_only_config_schema or cv.config_entry_only_config_schema can be used.

Error: Process completed with exit code 1.

see https://github.com/jeroenterheerdt/HAsmartirrigation/pull/238

jeroenterheerdt commented 9 months ago

Firefox, Vivaldi and Companion App. All caches deleted an restarted. Don't know what else. Also I don't see the new languages, it's all English for them.

neither do I.

jeroenterheerdt commented 9 months ago

When I push something to the repository I'm getting following since days:

Integration smart_irrigation - /github/workspace/custom_components/smart_irrigation:
Error: R] [SERVICES] Service reset_bucket has no name and is not in the translations file
Error: R] [SERVICES] Service set_bucket has no name and is not in the translations file
Error: R] [SERVICES] Service set_bucket has a field value with no name and is not in the translations file
Error: R] [SERVICES] Service calculate_hourly_adjusted_run_time has no name and is not in the translations file
Error: R] [SERVICES] Service calculate_daily_adjusted_run_time has no name and is not in the translations file
Error: R] [SERVICES] Service enable_force_mode has no name and is not in the translations file
Error: R] [SERVICES] Service disable_force_mode has no name and is not in the translations file
Warning: G] [CONFIG_SCHEMA] Integrations which implement 'async_setup' or 'setup' must define either 'CONFIG_SCHEMA', 'PLATFORM_SCHEMA' or 'PLATFORM_SCHEMA_BASE'. If the integration has no configuration parameters, can only be set up from platforms or can only be set up from config entries, one of the helpers cv.empty_config_schema, cv.platform_only_config_schema or cv.config_entry_only_config_schema can be used.

Error: Process completed with exit code 1.

see #238

not sure what this even is. I have never seen this before. Is this the result of a git command? What is your workflow? What tools do you use? What commands do you run? These errors refer to V1 stuff.

Oh I see now, I think you're seeing this as part of the validations online? Those are all based on V1, so ignore them.

gatonero commented 9 months ago

Thanks god!

Nonetheless for the record

  1. Commit & Push
  2. workfow? vscode,vscode-json, github, GitHub Pull Requests and Issues and some minor others like ssh, sftp, docker.
  3. Tools see above
  4. hardly at all cli git
  5. aha, understand
  6. Happy to ignore.

Maybe last words before one week holiday (just with a small mobile). :-)

jeroenterheerdt commented 9 months ago

enjoy your holiday and thanks for all your help!

gatonero commented 9 months ago

Thank you!

This morning I saw everything translated! 😋

jeroenterheerdt commented 8 months ago

Weird but glad it worked!