Entity's attributes should not be translated to system locale

juacas commented 7 months ago

In a system with Spanish language configured the attributes of the entities are created in spanish.

That is, the attribute "Throughput " is named "Rendimiento", "Size" is named "Tamaño" and so on.

It is not that the user interface translates them but that the registed identifiers are translated.

If language is changed and a new zone is created, then the attributes of the new zone are named in the configured locale:

The attributes should be in english and have predictible names.

Change language and create a new zone. Inspect the schema of the new zone..

No response

2023.9.2

No response

jeroenterheerdt commented 7 months ago

Why not? This is by design.

juacas commented 7 months ago

Hi I can think of some arguments:

HA developer's guide seems recommend to define key-hardcoded schema for the entities and to provide translations as i18n strings https://developers.home-assistant.io/docs/internationalization/core#entities
a known-stable schema allows the community to contribute with better automations, i.e. blueprints.
current implementation allows different zones to have different attribute names for the same value type in the same environment.
I can see no reason why the keys of a technical data structure should depend on the casual locale configured at one moment.
it is always better to let the frontend to translate things to the user. One never knows what language is going to use a user in the future. Why freeze the attribute names?
this is the only integration that I've seen to do this way. It is not usual. That's why I through it was a bug.

However, this is only a suggestion to improve your, otherwise, super useful component.

jeroenterheerdt commented 7 months ago

that makes sense, I can try to implement the translation according to the link you shared. thanks.

jeroenterheerdt / HAsmartirrigation