search

jeroenterheerdt / HAsmartirrigation

Smart Irrigation custom component for Home Assistant
MIT License
301 stars 47 forks source link

Added SOLRAD_behavior EstimateFromMean #345

Closed tefracky closed 3 weeks ago

tefracky commented 1 month ago

Added a new possibility to calclate the solrad value. It is the mean value of the sun hours and the temperature and called EstimateFromMean. It shoult improve the accuracy of a calculated solrad value.

jeroenterheerdt commented 3 weeks ago

I love this, but the name is not good. Please add a better name instead of EstimateFromMean.

tefracky commented 3 weeks ago

I am not a native English speaker, so do you have any suggestions?

jeroenterheerdt commented 3 weeks ago

neither am I, but since it's taking the average of the sunhours and the temperature, I'd propose something like EstimateFromSunHoursAndTemperature. Of course, update the descriptions in the language files as well.

For context, at first I was going to close this because it seemed to do exactly what EstimateFromTemp does, but only after looking at the code I realized that is actually not what it does. Imagine the confusion ti the user or future developer if we don't give things good names.

tefracky commented 3 weeks ago

It's done. I also fixed some markdown formatting in the Readme (tailing whitepaces and missing blank lines).