search

jeroenterheerdt / HAsmartirrigation

Smart Irrigation custom component for Home Assistant
MIT License
301 stars 47 forks source link

Changing the bucket - no impact on duration #347

Closed elenril2 closed 3 weeks ago

elenril2 commented 1 month ago

What happened?

When calling service _setbucket, I think there should be a change in the state of a given zone, directly affecting the irrigation time.

How to reproduce

Call service _setbucket

Relevant log output

There was no bucket change recorded in the log.

Which version are you running?

v2024.4.3

Diagnostics file

Additional information

I'm not sure if this is a bug, but I think there was this functionality in v1. When calling service _setbucket, there should be a change in the state of a given zone (seconds of watering), directly affecting the irrigation time.

I don't want to run the service _updatezone because it will just recalculate the bucket and erase the existing weather data points.

jeroenterheerdt commented 3 weeks ago

Investigating.

jeroenterheerdt commented 3 weeks ago

so we split the update and calculate steps in v2, which were one and the same in v1. that is causing this behavior. the issue here is that if we implemented what you suggested and effectively calculated after a bucket is set, we would also be removing the weatherdata used to calculate (that is an effect of calculate) and I am quite certain that is something we don't want as once the weatherdata is gone it's gone for all the zones that use that weatherdata. So you set one bucket (and calculated), but all other zones can now not calculate anymore based on the weatherdata collected so far. never say never, but its pretty hard to make this happen in this new set up.

How hard is it for you to change your logic to the following: -call set_bucket for the zones -call calculate

elenril2 commented 3 weeks ago

OK, thanks for your answer. I will use such a logic. I thought it was possible to just change the irrigation time (zone state) based on the bucket, without touching the weather data.

jeroenterheerdt commented 3 weeks ago

You are not wrong. I will keep thinking about this but I don't see a quick solution here yet.

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: elenril2 @.> Sent: Tuesday, April 23, 2024 10:35:30 PM To: jeroenterheerdt/HAsmartirrigation @.> Cc: Comment @.>; Assign @.>; Subscribed @.***> Subject: Re: [jeroenterheerdt/HAsmartirrigation] Changing the bucket - no impact on duration (Issue #347)

OK, thanks for your answer. I will use such a logic. I thought it was possible to just change the irrigation time (zone state) based on the bucket, without touching the weather data.

— Reply to this email directly, view it on GitHubhttps://github.com/jeroenterheerdt/HAsmartirrigation/issues/347#issuecomment-2074068899 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB6PIPVQYFYZ34DMJQ2N6YDY65ACFBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVIZDANJTHA4TIMJXG6SG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRWGIZTMNRSGA4TGNFENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZJAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUTENRTGE3TSMJXG2BKI5DZOBS2K2LTON2WLJLWMFWHKZNKGIZDIMZSG43DOMBRQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRSGA2TGOBZGQYTON4CUR2HS4DFUVWGCYTFNSSXMYLMOVS2UNRSGM3DMMRQHEZTJJ3UOJUWOZ3FOKTGG4TFMF2GK. You are receiving this email because you commented on the thread.

Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.