search

jeroenterheerdt / HAsmartirrigation

Smart Irrigation custom component for Home Assistant
https://jeroenterheerdt.github.io/HAsmartirrigation/
MIT License
362 stars 48 forks source link

[REQ] Change approach so ET is calculated in real-time for each sensor group and applied to zones daily or whenever #370

Open jata1 opened 5 months ago

jata1 commented 5 months ago

Is your feature request related to a problem? Please describe. Currently sensor group data is collected and ET calculated daily then applied to any zone that uses the sensor group. This is not ideal because:

Describe the solution you'd like I would like to see ET data for each sensor group held in separate sensor(s) with the ETO being recalculated each time sensor data is collected. This will allow you to:

Describe alternatives you've considered You can create duplicate sensor groups - e.g. create a group for each zone but it is a work-around and is still limited in that ET is only calculated at the point at which it is applied.

Additional context I know this is a big change to the overall design of this great integration but I think it is worth considering

jeroenterheerdt commented 5 months ago

Almost impossible without a complete rewrite since et is not calculated by sensor groups, but by modules which are confused on zones. I don't have time, bandwidth nor interest in doing this at the moment.

jeroenterheerdt commented 5 months ago

What's more, this is what our v1 did and we moved away from it because of it being very undefined what et value you'd want to take. It's simply a resolution problem : do you take the average of hourly et? Or minutely et? Neither are great and very prone to overfitting issues. Aggregation to the day level is the right approach IMO, but you indeed sacrifice the real time insight.

jata1 commented 5 months ago

I had a feeling it might be tricky but I thought I'd ask. I have only used v2 so wasn't aware you had tried this approach and moved away from it.

What about just having a 'button' that does the ET calculation for a zone based on the data but does not apply it?

jeroenterheerdt commented 5 months ago

It's an interesting experiment for sure. Right now let's focus on our other experiment for potential bugs before doing any other changes. Also, very busy with another integration as well. So, really, bug fixes is all I can do here for a while.

jata1 commented 5 months ago

all good. Thanks for the help. Sorry for all the questions!

what is your 'other integration'?

jeroenterheerdt commented 5 months ago

HADailysensor is already public. The other one is grillbuddy which I am still working on (it's not even version 0). Its basically a grill thermometer app for HA, but then more flexible and tech agnostic.

Kurisutian commented 4 months ago

HADailysensor is already public. The other one is grillbuddy which I am still working on (it's not even version 0). Its basically a grill thermometer app for HA, but then more flexible and tech agnostic.

Regarding that grill thermometer app, which hardware will this be working with? Any chance it will be compatible with something like https://wlanthermo.de/ ? Sorry to highjack the actual issue a little bit with this question. 😉

jeroenterheerdt commented 4 months ago

HADailysensor is already public. The other one is grillbuddy which I am still working on (it's not even version 0). Its basically a grill thermometer app for HA, but then more flexible and tech agnostic.

Regarding that grill thermometer app, which hardware will this be working with? Any chance it will be compatible with something like https://wlanthermo.de/ ? Sorry to highjack the actual issue a little bit with this question. 😉

Its hardware independent. As long as it's integrated with home assistant the answer is yes. Feel free to install it and try it: https://github.com/jeroenterheerdt/grillbuddy

jeroenterheerdt commented 4 months ago

@jata1 look at this -- a significant step towards direct continous updates of sensors and zones: https://github.com/jeroenterheerdt/HAsmartirrigation/releases/tag/v2024.6.7. please install and try. be careful: there will be bugs.