jeroentvb / spicetify-playlist-icons

Add the icon of a playlist in front of the playlist in the playlist list.
MIT License
42 stars 3 forks source link

increased beauty #3

Closed Tetrax-10 closed 2 years ago

Tetrax-10 commented 2 years ago

added rounded corner altered size of big icons

jeroentvb commented 2 years ago

Thank you for creating this PR. However, I'm not merging it for the following reasons:

With most of my spicetify extensions I'm aiming to extend stock spotify, and am trying to make the extensions fit in with the default theme. A border-radius of 10% doesn't fit with spotify's menu icon usage (I did notice they use 2px instead of 1px, so I updated that). I did bump up the border radius on the big icons to 4px, because I agree more looks better there.

The second reason is you committed to the dist file. That's the output generated from the build process. It's overwritten by the souce files every time a build is run. So your changes would get lost on the next run. The correct file to make styling changes would be styles.scss.
I've now changed the build process so it runs automatically on every push to the master branch, which builds the extension, and pushes it to the dist branch (to keep source and dist files separate). For this I also removed the dist folder from the master branch, so the file you changed doesn't exist in the master branch anymore.

If you still want to change the aesthetic of playlist icons, I'd recommend creating a css snippet via the marketplace, or creating a custom theme.