Closed dvv closed 13 years ago
i think i remember this jsdom case. i will look
about your suggestion on making it more resilient, seem a good thing ;) suppose node-waf crashs. what should i do ?
On Thu, Mar 10, 2011 at 5:28 PM, dvv < reply@reply.github.com>wrote:
Hi!
if
wscript
doesn't specify either ofdistclean, configure, build
, failure innode-waf
stops the whole download process. E.g. jquery depends on jsdom which has such wscript.Couldn't you make
nmod
survive if not-so-essential functions fail?TIA, --Vladimir
I think warn and go on. Stopping at the first error is good (but still unfriendly) for compilers. Letting the user know all errors encountered by nmod
would ease their fixing, imho.
Also, I noticed that running nmod
the second time doesn't start at where it died the first time. This causes way lenghty download if something goes wrong. I don't know how to classify this issue -- it's clearly not a bug, may be a design flaw.
Sorry for being pressing today, but just discovered your tool and am interested.
dont worry, i love when people are interested in what i do :) i will change it to make warn+continue.
about the download cache, on which package you experienced those lenghty download ?
On Thu, Mar 10, 2011 at 5:54 PM, dvv < reply@reply.github.com>wrote:
I think warn and go on. Stopping at the first error is good (but still unfriendly) for compilers. Letting the user know all error encountered by
nmod
would ease their fixing, imho.Also, I noticed that running
nmod
the second time doesn't start at where it died the first time. This causes way lenghty download if something goes wrong. I don't know how to classify this issue -- it's clearly not a bug, may be a design flaw.Sorry for being pressing today, but just discovered your tool and am interested.
https://github.com/jeromeetienne/nmod/issues/3#comment_856618
Well, I tried nmod install zappa
:) It dumps at fulfilling jquery deps (jsdom). I replaced failureCb
with successCb
at node-waf
section of nmod
and rerun. And it started from the very beginning.
Another BADBADBAD thing is that coffee code-which-require-module-foo
doesn't (so far, i hope -- i filed the issue to coffeescript) honor node_modules
. There must be explicit require.paths.unshift(__dirname + '/node_modules')
at the start of the script.
Since I love to use coffee, this hits me.
zappa has indeed quite a lot of deps. btw i commited the patch for node-waf to fall thru
jsdom error is just misconfiguration. it seems to be ok to ignore.
how long does it take for you to install zappa ?
$ time nmod install zappa ... real 0m29.465s
On Thu, Mar 10, 2011 at 6:04 PM, dvv < reply@reply.github.com>wrote:
Well, I tried
nmod install zappa
:) It dumps at fulfilling jquery deps (jsdom). I replacedfailureCb
withsuccessCb
atnode-waf
section ofnmod
and rerun. And it started from the very beginning.
Another BADBADBAD thing is that
coffee code-which-require-module-foo
doesn't (so far, i hope -- i filed the issue to coffeescript) honornode_modules
. There must be explicitrequire.paths.unshift(__dirname + '/node_modules')
at the start of the script.Since I love to use coffee, this hits me.
https://github.com/jeromeetienne/nmod/issues/3#comment_856659
yeah, I grabbed already. Works ok, though the final "All is OK" is truthy, not true ;) Circa 1.5 minutes, but it's due to slowness of my connection presumably.
Mind to take some critisism? Can I reach you somewhere at IRC?
sure, im on freenode as "jetienne"
On Thu, Mar 10, 2011 at 6:16 PM, dvv < reply@reply.github.com>wrote:
yeah, I grabbed already. Works ok, though the final "All is OK" is truthy, not true ;) Circa 1.5 minutes, but it's due to slowness of my connection presumably.
Mind to take some critisism? Can I reach you somewhere at IRC?
https://github.com/jeromeetienne/nmod/issues/3#comment_856702
closed
Hi!
if
wscript
doesn't specify either ofdistclean, configure, build
, failure innode-waf
stops the whole download process. E.g. jquery depends on jsdom which has such wscript.Couldn't you make
nmod
survive if not-so-essential functions fail?TIA, --Vladimir