search

jeromeetienne / threex.domevents

three.js extension which provide dom events inside your 3d scene.
http://jeromeetienne.github.io/threex.domevents/examples/demo.html
MIT License
246 stars 113 forks source link

Need browserify support #7

Open Deadarius opened 9 years ago

Deadarius commented 9 years ago

Three js currently supports browserify. But in this case it's impossible to use threex.domevents because it expects THREE on the global scope. Can you please confirm if this project is still maintained and I will get pull request accepted quickly if I do one?

jeromeetienne commented 9 years ago

i would accept if it isnt intrusive in the code.

btw im quite surprised at the claim 'three.js support browserify'. can you please point at the matching code?

Deadarius commented 9 years ago

I see your point, I will do it in a little bit less invasive way and submit another pull request if that's ok with you.

Regarding three.js browserify support - https://github.com/mrdoob/three.js/blob/master/src/Three.js#L9

jeromeetienne commented 9 years ago

make that a oneliner with a comment and im cool, thanks :)

On Wed, Apr 8, 2015 at 4:20 AM, Alex Lapa notifications@github.com wrote:

I see your point, I will do it in a little bit less invasive way and submit another pull request if that's ok with you.

Regarding three.js browserify support - https://github.com/mrdoob/three.js/blob/master/src/Three.js#L9

— Reply to this email directly or view it on GitHub https://github.com/jeromeetienne/threex.domevents/issues/7#issuecomment-90783055 .

Cride5 commented 7 years ago

Added basic support for browserify, pull request here: https://github.com/nitaigao/threex.domevents/pull/5