search

jeromeetienne / virtualjoystick.js

a virtual joystick library to emulate a joystick on touch screen in javascript
http://jeromeetienne.github.com/virtualjoystick.js/examples/basic.html
MIT License
417 stars 125 forks source link

Added Stationary-Base Demo and Updated README.md #15

Closed erichlof closed 10 years ago

erichlof commented 10 years ago

This PR updates the README.md file to give usage info for the new stationary-base feature.

This PR also adds (and links to in the Readme) my stationary-joystick demo to your existing 2 joystick demos (basic and dual) that are already here. I also created a new 'js' folder for my dependencies. I went ahead and copied the new virtualjoystick.js from your Master and placed it here in the 'js' dependencies folder because my demo requires this updated version.

Sorry I'm a little confused as to how hosting works on GitHub and which solution you are personally using for your demos. I'm assuming that your demos and their dependencies are being hosted by your .github.io pages. So I don't really know where the current demos are searching for their version of <src = 'virtualjoystick.js'. in their html files. If I have misunderstood where to place the dependencies and how they are hosted for your demo pages, I will be glad to make any changes necessary.

Thanks! -Erich

jeromeetienne commented 10 years ago

I looks at the patch of virtualjoystick.js and it looks like you modify each and every lines? I dont understant. Can you provide a patch where i can only the lines you modified

On Thursday, December 5, 2013, erichlof wrote:

You can merge this Pull Request by running

git pull https://github.com/erichlof/virtualjoystick.js patch-1

Or view, comment on, or merge it at:

https://github.com/jeromeetienne/virtualjoystick.js/pull/15 Commit Summary

  • Create StationaryBaseDemo.html
  • Update StationaryBaseDemo.html
  • Create threex.keyboardstate.js
  • Create virtualjoystick.js
  • Create StationaryBaseDemo.js
  • Update README.md

File Changes

  • M README.mdhttps://github.com/jeromeetienne/virtualjoystick.js/pull/15/files#diff-0(5)
  • A StationaryBaseDemo.htmlhttps://github.com/jeromeetienne/virtualjoystick.js/pull/15/files#diff-1(32)
  • A js/StationaryBaseDemo.jshttps://github.com/jeromeetienne/virtualjoystick.js/pull/15/files#diff-2(111)
  • A js/threex.keyboardstate.jshttps://github.com/jeromeetienne/virtualjoystick.js/pull/15/files#diff-3(150)
  • A js/virtualjoystick.jshttps://github.com/jeromeetienne/virtualjoystick.js/pull/15/files#diff-4(318)

Patch Links:

erichlof commented 10 years ago

Hi @jeromeetienne, Sorry I must have hit the wrong button when I created the fork. I will try again so I can 'compare' with the red and green GitHub colors like normal.

-Erich