search

jeromefroe / lru-rs

An implementation of a LRU cache
https://docs.rs/lru/
MIT License
644 stars 106 forks source link

Upgrade to hashbrown v0.13 #162

Closed benesch closed 1 year ago

jeromefroe commented 1 year ago

@benesch looks like we'll need to bump the MSRV to 1.61.0 in order to upgrade to hashbrown v0.13. Mind update the README and CI as part of this change? That should be all the additional changes we need.

benesch commented 1 year ago

Sure thing, done!

jeromefroe commented 1 year ago

Looks great! Thank you @benesch!

benesch commented 1 year ago

Thank you!

mrcnski commented 1 year ago

Hello there! I was a bit confused why lru version 0.9 is a breaking change, as it seemed to only affect internals. Is it because of this MSRV bump, mentioned in the OP? Should it have been called out in the changelog, perhaps?

jeromefroe commented 1 year ago

Hi @mrcnski! Yea, I cut a new minor tag instead of a patch one because of the MSRV bump. Sorry for the confusion, I should have called that out in the changelog 🤦

mrcnski commented 1 year ago

No worries at all @jeromefroe, thanks for clearing that up! Have a good day!