search

jeromegamez / mite-php

Interact with mite from your PHP application.
https://mite.yo.lk
MIT License
8 stars 2 forks source link

add PHP 8.3 support and remove `beste/json` #13

Closed LordSimal closed 10 months ago

LordSimal commented 11 months ago

Refs: https://github.com/jeromegamez/mite-php/issues/12

Well, here is what I did and what the current problem is.

The beste/json package is not PHP 8.3 ready yet but since it doesn't really do much I just replaced it with native json_encode and json_decode methods.

But there is also the issue, that Github CI doesn't work for PHP 8.3 yet because beste/php-cs-fixer-config is not yet PHP 8.3 ready. php-cs-fixer itself just recently released a 8.3 compatible version but the used dependency not yet.

jeromegamez commented 7 months ago

I had quite a lot going on in my life in the past year, but I'm still not sure why I missed your PR and the related issue, but I stumbled upon it when I wanted to add PHP 8.3 support myself (finally). In the meantime, the dependencies all got PHP 8.3 support themselves, so I simplified the change and added you as a co-author: 4a99dff2cabc57af89542c31d52c973dfffda87a

Thanks!

LordSimal commented 7 months ago

I have moved on to do my own, very minimal implementation of the mite api since neither do I need much from it nor does this package really provide much benefits for what I need (like converting the data from the API into PHP objects which are more telling to get properties from for example a "Project" class or a "TimeEntry" class)

Thanks for putting me inside that commit as a co-author and I wish you all the best for this package.

jeromegamez commented 7 months ago

Thanks, and thanks for letting me know! If you'd like, follow the releases of this package, I took the first steps to object mapping a few days ago as well... all the best to you, too!