search

jeromegamez / mite-php

Interact with mite from your PHP application.
https://mite.yo.lk
MIT License
8 stars 2 forks source link

Add support for psr/http-message v2 #9

Closed LordSimal closed 1 year ago

LordSimal commented 1 year ago

Hey there, fellow CakePHP core member here 😁

We just released CakePHP 5 RC1 and with that we upgraded to https://github.com/php-fig/http-message/releases/tag/2.0 which added return types.

So this package would require a new, separate version to be released with those added return types and the adjusted composer requirement for "psr/http-message": "^2.0" so that future CakePHP 5 users (and of course other frameworks which require psr/http-message v2) can use this awesome package 😁

jeromegamez commented 1 year ago

Thank you for the kind words, I really appreciate it! 🥰

I included psr/http-message as direct dependency because the ApiClient class uses them and I usually try to avoid transitive dependencies.

But in this case, the dependency is always included thanks to psr/http-client and psr/http-factory... how would you feel about removing it from the composer.json file altogether and make it a minor release?

LordSimal commented 1 year ago

how would you feel about removing it from the composer.json file altogether and make it a minor release?

this is fine by me as well 😁

jeromegamez commented 1 year ago

Done! https://github.com/jeromegamez/mite-php/releases/tag/3.1.0 🚀

LordSimal commented 1 year ago

Thank you!