search

jeromegn / DocumentUp

Pretty documentation generator for Github projects with proper Readme.
http://documentup.com
884 stars 90 forks source link

Add GoatCounter, Plausible, Matomo and Fathom support #111

Closed resynth1943 closed 3 years ago

resynth1943 commented 4 years ago

Hey @jeromegn, how is the code?

Feel free to fix it up, my Ruby-fu may be failing me. :stuck_out_tongue:

resynth1943 commented 4 years ago

I'm also planning to add support for Fathom, but that's a project for tomorrow.

jeromegn commented 4 years ago

This is looking good.

Looks like you need to rename your classes to remove the Configuration:: bit. Rails is a bit strict on how you name things in the project structure.

Also: wow, there's some very old code in there.

resynth1943 commented 4 years ago

Just updated things a little. Hopefully it works ...?

jeromegn commented 4 years ago

Looks better, but there's another error with GoatCounter. The file needs to be named goat_counter.rb for Rails to convert it to GoatCounter. Right now it assumes it's Goatcounter.

resynth1943 commented 4 years ago

Haha, I'll fix that. Aside from that, it looks like I'm on a winning streak with Ruby and Rails. :stuck_out_tongue: