jeromegn / DocumentUp

Pretty documentation generator for Github projects with proper Readme.
http://documentup.com
883 stars 90 forks source link

Linked Images are not parsed correctly #23

Closed dlindahl closed 9 years ago

dlindahl commented 12 years ago

Images wrapped in anchor tags are not parsed correctly:

# My App [![Build Status](https://secure.travis-ci.org/dlindahl/my_app.png)][travis] [![Dependency Status](https://gemnasium.com/dlindahl/my_app.png?travis)][gemnasium]

Outputs:

My App ![Build Status][travis] ![Dependency Status]gemnasium
jeromegn commented 12 years ago

Interesting.

Looks like an issue with marked.js. I can file on their repo.

jackhl commented 12 years ago

Vote to close, seems to be fixed on at least the gh-pages version. (ex: http://jlawr3nc3.github.com/aboutobjects.github.com)

jeromegn commented 12 years ago

I have seen it broken elsewhere.

@Jlawr3nc3 Crisp logo :)

dlindahl commented 12 years ago

Assuming that latest.min.js will automatically include the latest version, I'm still seeing bad parsing:

http://dlindahl.github.com/omniauth-cas/

jackhl commented 12 years ago

How is your markdown formatted? I found that referencing the urls worked more consistently for me:

[![Logo][2]][1]

[1]: http://mysite.com

[2]: http://mysite.com/logo.png
dlindahl commented 12 years ago

@Jlawr3nc3 That seems to have done the trick.

I still think that this is a bug, just with an easy work around.

If there is a matching bug with marked.js, then let's get it linked in to this discussion. Then it should be OK to close this since it appears to not be an issue with DocumentUp.

jeromegn commented 12 years ago

Not sure what to do about this. It does look like it's due to marked.js.

I might have to contribute myself some code to this library.

itsjavi commented 12 years ago

I had problems with case of repo name too: Travis is case sensitive and documentup lowercases your repo name by default.

jeromegn commented 9 years ago

Should be fixed with the recent rewrite.