search

jeromegn / DocumentUp

Pretty documentation generator for Github projects with proper Readme.
http://documentup.com
884 stars 90 forks source link

Issue #19 Default Branch? #61

Closed iskigow closed 11 years ago

iskigow commented 11 years ago

This changes make the project to get .documentup.json or documentup.json from the default branch. Maybe the _getRaw and getFile on github.coffee are no longer needed

jeromegn commented 11 years ago

Tests are failing.

Make sure you test your stuff with the npm test command to know if it works.

iskigow commented 11 years ago

I didn't know abot the npm test. I am a newbie in node.js, coffeescript and npm. But this project help me to understand more about it. Thanks for all!

jeromegn commented 11 years ago

I'm impressed by how fast you picked it up!

The benefit of getting the raw contents is that it doesn't count towards the Github API rate limit. But since DocumentUp isn't using anywhere near the 5000 allowed calls, I guess this is fair :)

Going to review this very soon and merge as soon as I'm sure it's not breaking stuff.

jeromegn commented 11 years ago

Merged and deployed :)

Thanks @iskigow!