search

jeromegn / DocumentUp

Pretty documentation generator for Github projects with proper Readme.
http://documentup.com
884 stars 90 forks source link

HTTPS broken #88

Closed akre54 closed 9 years ago

akre54 commented 9 years ago

Heads up, NYTimes/backbone.stickit#272 noted that https is broken (getting a 521 response) but not http. Any ideas?

jeromegn commented 9 years ago

I could be wrong, but I think this has to do with an express config setting. DocumentUp uses Cloudflare (which supports HTTPS, but only recently) and so the trust proxy setting needs to be enabled on Express so that it accepts the connection. That trust proxy setting (or flag) is only available in express >= 3.

Probably means upgrading Express is required to get this to work. In any case, it's probably a good thing to upgrade.

jeromegn commented 9 years ago

I believe this is now fixed.

akre54 commented 9 years ago

Yup, looks like it's fixed. Thanks!