search

jeromejj / vim

Automatically exported from code.google.com/p/vim
0 stars 0 forks source link

Use 'path' setting for filename completion (compl-filename) #79

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The help for i_CTRL-X_CTRL-F states:

"Note: the 'path' option is not used here (yet)."

It would be great if that feature would be added.

I am using Vim 7.3.429 (Ubuntu).

Original issue reported on code.google.com by dhahler@gmail.com on 14 Aug 2012 at 10:26

GoogleCodeExporter commented 9 years ago

Original comment by pawel.pa...@gmail.com on 14 May 2015 at 9:15

Attachments:

GoogleCodeExporter commented 9 years ago 
My first contribution, so what next steps are required to actually accept this 
patch ? Should I write some unit tests ? Ask for review on vim-dev ?

Original comment by pawel.pa...@gmail.com on 14 May 2015 at 9:24

Attachments:

GoogleCodeExporter commented 9 years ago 
During testing I spotted "unexpected" behavior. When `path` contains more than 
one entry, for absolute entries, instead of completion, it replaces whole 
pattern with absolute path.

It can be disqualifying, because it is different that users accustom to (simple 
completion).

Original comment by pawel.pa...@gmail.com on 14 May 2015 at 10:30

GoogleCodeExporter commented 9 years ago 
Thanks for your contribution. It's appreciated. Note, that vim develops slowly 
and the main focus is fixing bugs. Considering the todo.txt file, it might take 
some time until your patch will be merged, but don't let this scare you away!

It would be great, if you could contribute a test. Look in the src/testdir/ 
directory and add a new file called test_expand_filename or something. 

BTW: to discuss issues/questions regarding the behaviour, it might be better to 
directly ask on vim-dev ml.

Original comment by chrisbr...@googlemail.com on 15 May 2015 at 8:37