Closed hyanwong closed 1 year ago
I'll follow the order in Yan's figure, i.e., inserted node, recombination node, sample node, newly added sample node.
Please ignore the red squiggly line.
Seems good. Should we have BASE in caps (as the letters are caps). I think it would be helpful to say "optional" or "may be labelled" too, so e.g.
Mutation (may be labelled BASEpositionBASE)
Might it be confusing to put the label in orange when only some of the mutation labels are orange? I guess it's OK / clear though?
I need to change the order (very slightly) in the subgraphs to match this. I'll capitalise the labels too.
I'm just going with "Mutation (labelled BASEpositionBASE)". It gets too long otherwise, I think.
I'm just going with "Mutation (labelled BASEpositionBASE)". It gets too long otherwise, I think.
SGTM. (labels: BASEpositionBASE)
is a tiny bit shorter (but perhaps less obvious) if that helps.
I made that piece of text a bit smaller than the "Mutation" text. It looks better, I think.
If we want to have complete consistency between figs 1 and 6 (although each of these is completely optional) we might want to
a) Put the order of legend labels (inserted node, recombination node, sample node, newly added sample node) in the same order (see https://github.com/jeromekelleher/sc2ts-paper/issues/156#issuecomment-1576328362) b) Use the same colour to label mutations (fig 1 uses black/orange for labels & blue bars for mutations, fig 6 uses dark red for numerical count) c) as part of the point above, we might want to place blue bars instead of a number of mutations along a branch. I think this would look nicer and be more visually informative, but it's too much work for the preprint.