jeromekelleher / sc2ts

Infer a succinct tree sequence from SARS-COV-2 variation data
MIT License
4 stars 3 forks source link

Mutations reported in copying pattern incorrect #92

Open jeromekelleher opened 1 year ago

jeromekelleher commented 1 year ago

copying-mutations-wrong

We're not showing the mutations for a recombinant correctly in the copying patterns. In this case for the 824607 recombinant for XC, we're showing zero mutations, but there was actually 8 mutations. It looks like these are above the single child of the recombinant.

The function is doing the right thing, in it's showing the mutations above the node in the tree, but this isn't helpful for understanding the recombinant itself.

Maybe we'd be better off having a dedicated summarise_recombinant function which took a recombinant node as a parameter, and then generated a copying table based on the metadata?

cc @hyanwong